From cdf90ff58248403ce917c4bbf0f9431bceaf1f47 Mon Sep 17 00:00:00 2001 From: Mo Tarbin Date: Wed, 4 Dec 2024 19:08:22 -0500 Subject: [PATCH] fix: Handle invalid frequency in ChoreEdit component --- src/views/ChoreEdit/ChoreEdit.jsx | 4 ++-- src/views/ChoreEdit/RepeatSection.jsx | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/views/ChoreEdit/ChoreEdit.jsx b/src/views/ChoreEdit/ChoreEdit.jsx index a0c5fd4..958ab08 100644 --- a/src/views/ChoreEdit/ChoreEdit.jsx +++ b/src/views/ChoreEdit/ChoreEdit.jsx @@ -113,8 +113,8 @@ const ChoreEdit = () => { if (assignedTo < 0) { errors.assignedTo = 'Assigned to is required' } - if (frequencyType === 'interval' && frequency < 1) { - errors.frequency = 'Frequency is required' + if (frequencyType === 'interval' && !frequency > 0) { + errors.frequency = `Invalid frequency, the ${frequencyMetadata.unit} should be > 0` } if ( frequencyType === 'days_of_the_week' && diff --git a/src/views/ChoreEdit/RepeatSection.jsx b/src/views/ChoreEdit/RepeatSection.jsx index d68257e..f9a578c 100644 --- a/src/views/ChoreEdit/RepeatSection.jsx +++ b/src/views/ChoreEdit/RepeatSection.jsx @@ -124,12 +124,15 @@ const RepeatOnSections = ({ Every: { - if (e.target.value < 1) { - e.target.value = 1 - } onFrequencyUpdate(e.target.value) }} />