amy/donetick
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor AssignLabelsToChore function to optimize label assignment and avoid unnecessary

Browse source
This commit is contained in:
Mo Tarbin 2024-11-27 19:14:16 -05:00
parent d3792f8e7b
commit a0265de264
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
internal/label/repo/repository.go
View file

@ -73,17 +73,19 @@ func (r *LabelRepository) AssignLabelsToChore(ctx context.Context, choreID int,
}) })
} }
return r.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error { return r.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
if len(toBeRemoved) > 0 {
if err := r.db.WithContext(ctx).Where("chore_id = ? AND user_id = ? AND label_id IN (?)", choreID, userID, toBeRemoved).Delete(&chModel.ChoreLabels{}).Error; err != nil { if err := r.db.WithContext(ctx).Where("chore_id = ? AND user_id = ? AND label_id IN (?)", choreID, userID, toBeRemoved).Delete(&chModel.ChoreLabels{}).Error; err != nil {
return err return err
} }
}
if len(toBeAdded) > 0 {
if err := r.db.WithContext(ctx).Clauses(clause.OnConflict{ if err := r.db.WithContext(ctx).Clauses(clause.OnConflict{
Columns: []clause.Column{{Name: "chore_id"}, {Name: "label_id"}, {Name: "user_id"}}, Columns: []clause.Column{{Name: "chore_id"}, {Name: "label_id"}, {Name: "user_id"}},
DoNothing: true, DoNothing: true,
}).Create(&choreLabels).Error; err != nil { }).Create(&choreLabels).Error; err != nil {
return err return err
} }
}
return nil return nil
}) })
} }