amy/donetick
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #53 Completing a task multiple times with "Reschedule from completion date" pushes it further into the future

Browse source
This commit is contained in:
Mo Tarbin 2024-12-21 01:49:04 -05:00
parent 472e78fc5e
commit b9160bf681
1 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/chore/scheduler.go
View file

@ -42,14 +42,6 @@ func scheduleNextDueDate(chore *chModel.Chore, completedDate time.Time) (*time.T
baseDate = time.Date(baseDate.Year(), baseDate.Month(), baseDate.Day(), t.Hour(), t.Minute(), 0, 0, t.Location()) baseDate = time.Date(baseDate.Year(), baseDate.Month(), baseDate.Day(), t.Hour(), t.Minute(), 0, 0, t.Location())
} }
if chore.IsRolling && chore.NextDueDate.Before(completedDate) {
// we need to check if chore due date is before the completed date to handle this senario:
// if user trying to complete chore due in future (multiple time for insance) due date will be calculated
// from the last completed date and due date change only in seconds.
// this make sure that the due date is always in future if the chore is rolling
baseDate = completedDate.UTC()
}
if chore.FrequencyType == "daily" { if chore.FrequencyType == "daily" {
nextDueDate = baseDate.AddDate(0, 0, 1) nextDueDate = baseDate.AddDate(0, 0, 1)